Add grid-template-columns to<CardGrid>
#2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1cccb5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
HiDeoo
approved these changes
Nov 19, 2024
Merged
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
Nov 19, 2024
* main: [ci] release (withastro#2615) [ci] format feat: add Backstage social icon (withastro#2600) Add SidebarPersister specifier to Starlight package (withastro#2605) Fix i18n type issue with multiple data content collections (withastro#2611) Fix sidebar issue in custom pages with custom sidebar (withastro#2614) Fix `sidebar` frontmatter use in internal links (withastro#2613) Add `grid-template-columns` to`<CardGrid>` (withastro#2606) i18n(zh-cn): Update `site-search.mdx` (withastro#2604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a base
grid-template-columnsrule to the<CardGrid>component to apply on smaller screens as one100%wide column.This helps avoid overflow when there is complex content inside the grid children. We already apply this rule as an override in Astro Docs to avoid overflow, but I only just remembered to upstream this.
Why can this be an issue? Without an explicit column width, the grid uses an implicit width based on context. For example, without this rule, cards on the Astro Docs homepage would overflow due to the code block in the “Start a new project” card:
Adding an explicit column width avoids that and ensures children are constrained as expected: