-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to documents not loaded #586
Comments
David, Sorry you're frustrated, that's definitely not the experience we want to provide. Unfortunately, saving/loading is a rough edge right now, because there are many ways it can go wrong... you found one of them. I can reproduce your issue like so:
Are those the steps you took? So it looks like the issue here is that changes are being saved to disk, and not to local storage. When you navigate away and back to the code, the code is only being loaded from local storage (where the change was not save) and then when you refresh the page, the file is being pulled from the disk (where the change was saved)
Yes, this isn't currently supported. I'll make an issue to track this: #595 |
@joshuafcole so I think the issue is that for a fresh load we get information from the server, when you use the ToC to navigate we're loading from local storage. |
A hard refresh is currently required to update the local cache. The current However, I'm not sure that's really the issue here? A hard refresh should On Tue, Nov 22, 2016 at 1:30 PM Chris Granger notifications@github.com
|
The problem is that it's unexpected. The user just edited the file in the browser, went away and came back, and his changes are gone. The reaction there is panic and frustration, at the thought of just losing all of the code you just typed. |
Not just unexpected it trivially leads to lost work. Make some changes, navigate, come back, make some more changes. You just lost your first set. |
I'm really sure when i reported this issue a simple reload dosn't help. I had updated to a919225 and now that works. As @ibdknox stated, i also have overwritten my first changes. It was just some simple tests but i stopped there playing around. This is actually a very interesting project and i like to play around with it. I hope my bugreports help to improve the user expereance. Keep up the good work! |
@davidak absolutely, we know where the problem is here, so thanks for the help :) |
quick fix for #586. A more durable solution is inbound
@davidak apologies for the long delay on fixing this. I hadn't understood the severity of this issue or it would have been my first priority. This sort of faux pas won't happen again. Even as a new language it's critically important that we look out for our users first and foremost. The current release (0.2.2) doesn't make this experience as good as it needs to be, but it eliminates this case that leads to trivially lost work. Until the more robust solution is in place, It's still dangerous to edit via the editor, an external editor, and the editor again. Fixing that unfortunately necessitates a little restructuring work, but it's on the top of my todo list. I'm going to close the issue here and track the remaining work in #635. As ever, feel free to comment with any other issues or concerns, and thanks again for your patience. |
i used
test.eve
to test out some things, open another example and go back but my changes are gone :(they are actually saved to the filesystem but not loaded again.
very frustrating!
then i created a new document. it's name is
untitled.eve
and i can't change the name in the IDE. also when i add content and reload the browser or came back from another example, it is empty again. but again it is saved, but not loaded again!Eve git master at 59f6ec9
node v6.9.1
npm 3.10.8
elementary OS 0.4 Loki (Ubuntu 16.04 based)
The text was updated successfully, but these errors were encountered: