-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Npm package #598
Merged
Merged
Npm package #598
Changes from 10 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
469bea3
npm-ready package.json
joshuafcole ce86bb9
Merge branch 'feature/npm-package' into app-loading
joshuafcole cd7db0b
merge
joshuafcole 5313990
location-independent Eve binary WIP
joshuafcole 2fa8531
Pull config out into module, add npmignore, update build phase for pa…
joshuafcole db9d0ad
Remove workspaces rewrite from server (doesnt work when installed -g)
joshuafcole 074db56
Update readme
cmontella 6cf8fb5
Fix package-workspaces script to include eve src workspace
joshuafcole 7d4429f
Add eveSource.find to resolve a workspace-relative URL to a file
joshuafcole 1b657c1
Fix fully local-initialization
joshuafcole d521b45
Merge branch 'npm-package' of github.com:/witheve/eve into npm-package
joshuafcole 8b8b96b
Add fixme about file arg in eve binary
joshuafcole 76c29fd
Fix crash when trying to load nonexistent document
joshuafcole 1d34dfb
Fix crash when loading nonexistent document, add getRelativePath, don…
joshuafcole 03ab7c3
Only attempt to load sane documents
joshuafcole 0679a34
Dont explode when initializing without code
joshuafcole 58463ac
Fix editor workspace/document loading in external projects
joshuafcole bd67f07
Fix port flag not overriding ENV and file argument following a boolea…
joshuafcole 2d08d27
Remove console logs
joshuafcole e3aaa1a
Remove vestigial code
joshuafcole a24ecae
Standardize variable names
joshuafcole 10f0dc1
Move document saving into eveSource and separate runtimeOwner and con…
joshuafcole c24d114
Fix loading quickstart on global install + local control when running…
joshuafcole deb8277
Fix broken path logic
joshuafcole 0b00981
Dont explode on non-existent documents
joshuafcole 22d763e
Do stricter url normalization
joshuafcole 6b24a5d
Recombobulate eve document resolution
joshuafcole File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why > 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to be remotely valid it needs to contain at least a character and a slash. Honestly it should be 3, since all files must at least be /
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably worth putting a comment in or maybe a regex or something?