Format tests #630
Merged
Format tests #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuafcole
reviewed
Dec 1, 2016
| @@ -223,8 +223,7 @@ testSingleExpressionByList(toFixed_list ); | |||
| test("Test that string concatenation is still working after NaN change.", (assert) => { | |||
| let expected = { | |||
| insert: [ | |||
| ["a", "tag", "div"], | |||
| ["a", "text", "Test Testy"], | |||
| ["a", "result", "Test Testy"], | |||
There was a problem hiding this comment.
Not especially important, but what's the rationale for choosing result over the existing text?
There was a problem hiding this comment.
I was making it consistent with the rest of the tests.
| [#div text: x] | ||
|
|
||
| bind | ||
| [result: x] |
There was a problem hiding this comment.
Do we have an alternative way to see these guys working?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just changed some formatting in tests to make more consistent