Added AsXxxCase wrappers #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized I am using an old base. I'll rebase it later after the changes are approved. |
|
I like the idea, though don't have time to review right now. Will try to get to this soon-ish. |
jplatte
approved these changes
Jul 30, 2021
|
Rebased. |
SOF3
commented
Jul 31, 2021
| pub use title::{AsTitleCase, ToTitleCase}; | ||
| pub use upper_camel::{ | ||
| AsUpperCamelCase, AsUpperCamelCase as AsPascalCase, ToPascalCase, ToUpperCamelCase, | ||
| }; |
There was a problem hiding this comment.
I would have actually preferred simply doing pub use upper_camel::*; here though.
|
When are you going to publish a release containing this update? |
|
I'm not sure it makes sense to release 0.4.0 before #26 is done, but this project is overall very low on my todo list. I guess this could go into 0.3.4 though. Can you rebase this on top of the v0.3.x branch and open another PR with that? If you care, finishing #27 would be another nice to have for v0.3.x, seems like the original author has disappeared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
camel: &str, snake: &str, the following line allocates 3Strings:Instead, I can write this to allocate only one
String