Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

Update markdown and ws dependencies #2644

Merged
merged 7 commits into from
Mar 23, 2018
Merged

Update markdown and ws dependencies #2644

merged 7 commits into from
Mar 23, 2018

Conversation

brianlovin
Copy link
Contributor

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • iris (api)
  • hyperion (frontend)

package.json Outdated
@@ -80,10 +80,11 @@
"draft-js-drag-n-drop-plugin": "2.0.0-rc9",
"draft-js-embed-plugin": "^1.2.0",
"draft-js-focus-plugin": "2.0.0-rc2",
"draft-js-fork-mxstbr": "npm:draft-js-fork-mxstbr",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That happened automatically...should that not be there?

mxstbr
mxstbr previously approved these changes Mar 22, 2018
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I guess

@brianlovin
Copy link
Contributor Author

Ah, now all tests are failing!

@brianlovin
Copy link
Contributor Author

Discussion here, but can't grok a clear solution: jestjs/jest#5119

@brianlovin
Copy link
Contributor Author

Updating jest didn't seem to work

@brianlovin
Copy link
Contributor Author

Looks like possibly conflicting test environments for our static tests and create-react-app?

@brianlovin
Copy link
Contributor Author

I've attempted to swap out jest for jest-cli, updated deps in iris/package.json, but still nothing. Ref jestjs/jest#5401

@brianlovin
Copy link
Contributor Author

People are saying to downgrade jest to 20.0.4, but that breaks because we need features that were introduced in jest 22.0.x lol

cc @mxstbr

@mxstbr
Copy link
Contributor

mxstbr commented Mar 23, 2018

What the fuck, tests work perfectly fine for me locally on the alpha branch. Going to try this one.

@mxstbr
Copy link
Contributor

mxstbr commented Mar 23, 2018

Can repro locally now

@mxstbr
Copy link
Contributor

mxstbr commented Mar 23, 2018

This was the problem: jestjs/jest#5119 (comment)

Fixed by ignoring the Jest from react-scripts by adding the latest version to the resolutions field from yarn! 🎉 Works locally, let's hope CI passes then I'll merge this and merge it into #2354 and we can finally get on with our lives.

@mxstbr mxstbr merged commit f85cea8 into alpha Mar 23, 2018
@mxstbr mxstbr deleted the update-package-vs branch March 23, 2018 09:24
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants