Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more side menu animation styles #38

Closed
wants to merge 2 commits into from
Closed

add more side menu animation styles #38

wants to merge 2 commits into from

Conversation

gran33
Copy link
Contributor

@gran33 gran33 commented Mar 31, 2016

No description provided.

@gran33
Copy link
Contributor Author

gran33 commented Apr 7, 2016

@talkol
Some updates:

  • Merge issue How to disable press event on swiping? #18
  • Share common code between the 2 drawers to avoid code duplication (RCCDrawerHelper object with public methods only, no instances on RCCDrawerHelper)
  • Reorder the Drawers files (1 directory to all files related to the drawers)
  • Add props support gestureMode="false/true" to avoid open/close the drawer via pan gesture
  • Add props support showsShadow="false/true" to show/hide the small shadow strip in the drawer
  • When drawer is open, the content screen (the one that pushed by the drawer) have a dark overlay only when drawer is open/close via the button (no gesture support yet, soon to come)
  • When drawer is open, the status bar is hidden only in the more... options (it's completely different type of drawer), have some conflicts with the RCCViewController functionality

I'll invest some more time to complete this pull request as fast as possible.

@drorbiran
Copy link
Contributor

Hi, we wanted to update you that we are currently postponing the processing of pull requests.
Please refer to React native controllers evolution, we'll appreciate your feedback.

@DanielZlotin
Copy link
Contributor

DanielZlotin commented Aug 23, 2016

@gran33 Is this PR fixing bugs? or features? Did you push it manually or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants