Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add programmatic control of TabBar upper border. #66

Closed
wants to merge 2 commits into from
Closed

Add programmatic control of TabBar upper border. #66

wants to merge 2 commits into from

Conversation

heysailor
Copy link

@heysailor heysailor commented Jun 21, 2016 •
edited
Loading

Adds two improvements:

  1. Optional removal of TabBar upper border with the tabsStyle property hideTabBarSeperator: true - without using transparent images.
  2. Correct positioning of TabBarItem icons when no label is set for an item. Without this, the icons are too high. With this, they are vertically centred in a the tab bar.

@drorbiran
Copy link
Contributor

Hi, we wanted to update you that we are currently postponing the processing of pull requests.
Please refer to React native controllers evolution, we'll appreciate your feedback.

@drorbiran drorbiran closed this Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
React native controllers evolution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heysailor @drorbiran