fix(DetoxActions): use is-hittable assertion before UI gestures.

wix · Dec 2, 2021 · ca1cde1 · ca1cde1
1 parent a45f6bd
commit ca1cde1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/detox/ios/Detox/Actions/UIDatePicker+DetoxActions.m b/detox/ios/Detox/Actions/UIDatePicker+DetoxActions.m
@@ -13,7 +13,7 @@ @implementation UIDatePicker (DetoxActions)
 
 - (void)dtx_adjustToDate:(NSDate*)date
 {
-	[self dtx_assertVisible];
+	[self dtx_assertHittable];
 
 	NSDate* previousDate = self.date;
 

diff --git a/detox/ios/Detox/Actions/UIPickerView+DetoxActions.m b/detox/ios/Detox/Actions/UIPickerView+DetoxActions.m
@@ -14,7 +14,7 @@ @implementation UIPickerView (DetoxActions)
 
 - (void)dtx_setComponent:(NSInteger)component toValue:(id)value
 {
-	[self dtx_assertVisible];
+	[self dtx_assertHittable];
 
 	DTXViewAssert(self.dataSource != nil && self.delegate != nil, self.dtx_elementDebugAttributes, @"The picker view's data source and/or delegate are nil");
 

diff --git a/detox/ios/Detox/Actions/UIScrollView+DetoxActions.m b/detox/ios/Detox/Actions/UIScrollView+DetoxActions.m
@@ -289,6 +289,9 @@ - (void)_dtx_scrollWithOffset:(CGPoint)offset normalizedStartingPoint:(CGPoint)n
 	}
 
 	CGPoint startPoint = CGPointMake(safeAreaToScroll.origin.x + safeAreaToScroll.size.width * normalizedStartingPoint.x, safeAreaToScroll.origin.y + safeAreaToScroll.size.height * normalizedStartingPoint.y);
+
+
+	[self dtx_assertHittableAtPoint:startPoint];
 
 	NSUInteger successfullyAppliedScrolls = 0;
 	while (offset.x != 0.0 || offset.y != 0.0)