Interactive touch outside React-Native-Navigation Overlay when detox run #2834

hqdai · 2021-06-14T08:56:22Z

Description

I'm using React-native-navigation (RNN) with an overlay is showing as alert, my issue is when manual test, I can't touch outside the alert message, that is correct, but when detox runs for automation test, it can touch and scroll outside the alert area.

So, the problem is why Detox can interact outside the overlay area ...

I have tested this issue on the latest Detox release and it still reproduces.

Reproduction

To reproduce, please check out my pet project and just do the test run. You can see detox can scroll even though the alert message is shown on top. Please be noted that I've turned option: interceptTouchOutside: true already.

Screen.Recording.2021-06-14.at.15.43.23.mov

Interactive 2.zip

Environment:

Detox: 18.16.0
React Native: 0.64.1
Node: 14.10.1
Device: iPhone 12 (Simulator)
Xcode: 12
iOS: 14.5
macOS: 11.3

noomorph · 2021-06-18T12:09:51Z

@hqdai, sorry for replying late.
Thanks for providing the example project.
Hopefully we can check it next week.

stale · 2021-07-18T12:37:50Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

stale · 2021-07-25T14:14:50Z

The issue has been closed for inactivity.

hqdai · 2021-07-29T10:28:46Z

@hqdai, sorry for replying late.
Thanks for providing the example project.
Hopefully we can check it next week.

Thank you @noomorph :D, it seems the issue still happens. Please reopen the issue.

d4vidi · 2021-08-01T20:06:06Z

@hqdai Detox has super powers 😄
I wonder whether it is plausible that touch events get somehow associated with specific views (based on interactability & visibility). @alon-ha would you mind taking a look into this sometime next week? There's an example project here ready to go.

alon-ha · 2021-08-08T12:01:44Z

Will check it this week and update

stale · 2021-09-07T12:57:06Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

phuongwd · 2021-09-09T09:26:39Z

Not stale,

phuongwd · 2021-09-09T09:31:21Z

Hello @alon-ha,
Could you please give me an update?

Many thanks

d4vidi · 2021-09-09T11:40:26Z

No updates so far, we apologize.

phuongwd · 2021-09-12T14:25:24Z

No updates so far, we apologize.

No problems, just checking to update our progress 😊

Thanks for quick response 😍

stale · 2021-10-12T14:30:14Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

phuongwd · 2021-10-14T14:56:01Z

Not stale

stale · 2021-11-19T11:07:24Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

Failed test: `scroll interactions -> should not be intractable when overlay is shown`.

…t visible. This fixes the bug reported on this issue: wix#2834.

This fixes the bug reported on this issue: wix#2834.

asafkorem · 2021-11-29T16:45:28Z

Thanks @hqdai for reaching out with this bug report!
This PR solves the bug you described.

This fixes the bug reported on this issue: wix#2834.

Failed test: `scroll interactions -> should not be intractable when overlay is shown`.

This fixes the bug reported on this issue: wix#2834.

Failed tests: - `scroll view -> should not be scrollable when overlay is shown`. - `button -> should not be hittable when overlay is shown`.

* fix(34.visibility.test.js): await for element matching. * fix(DetoxPolicy): remove `percentDescriptionForValue` method. Replaces this error message: `View “<RCTView: 0x7fa3020598b0>” is not visible: View is clipped by one or more of its superviews' bounds and does not pass visibility percent threshold (7,500)`, With this error message: `View “<RCTView: 0x7fa3020598b0>” is not visible: View is clipped by one or more of its superviews' bounds and does not pass visibility percent threshold (75)`. * iOS(Test App): add native method for presenting overlay window. * iOS(Test App): write failed detox tests (to reproduce #2834). Failed tests: - `scroll view -> should not be scrollable when overlay is shown`. - `button -> should not be hittable when overlay is shown`. * fix(iOS): rewrite `isHittable` check logic. Rewrite the logic: - Finds a visible point of the view (otherwise the view is not hittable). - Finds the topmost window, tries to tap on the visible point using `hitTest`. - Checks whether the hitted view is the view itself / descendent of the tested view. * fix(DetoxActions): use is-hittable assertion before UI gestures. * fix(isHittable): check if view is hittable from first responder. * UIView+DetoxUtils: remove redundant EL. * fix(actions): use the correct coordinates systems. * fix(DetoxUtils): fix `error` handling. * fix(DetoxUtils): add nullable flag to error's value. * UIResponder+First: add reference to the source SO thread. * UIScrollView+DetoxActions: make informative assertion. * 03.actions.test.js: add expectations. * 03.actions-scroll.test.js: add tests for covered scroll view. * 03.actions-scroll.test.js: fix android test fail (due to timeout). * 03.actions.test.js: expect only on iOS. * Publish 19.3.0-smoke.0 [ci skip] * 03.actions.test.js: replace TODOs with reference to issue. * fix(33.attributes.test.js): expect both subviews to be hittable. Co-authored-by: wixmobile <mobile1@wix.com>

This change reverts #3150, and adds the following changes (hit-test): - #3149 - #3145 - #3115 Those changes resolves this issue #2834.

hqdai added type: triage/bug platform: ios labels Jun 14, 2021

stale bot added the 🏚 stale label Jul 18, 2021

stale bot closed this as completed Jul 25, 2021

d4vidi reopened this Aug 1, 2021

stale bot removed the 🏚 stale label Aug 1, 2021

stale bot added the 🏚 stale label Sep 7, 2021

stale bot removed the 🏚 stale label Sep 9, 2021

stale bot added the 🏚 stale label Oct 12, 2021

stale bot removed the 🏚 stale label Oct 14, 2021

d4vidi assigned asafkorem Oct 20, 2021

d4vidi added this to the Q4/2021 Bugathon milestone Oct 20, 2021

stale bot added the 🏚 stale label Nov 19, 2021

d4vidi added 📌 pinned and removed 🏚 stale labels Nov 21, 2021

asafkorem added a commit to asafkorem/Detox that referenced this issue Nov 29, 2021

iOS(Test App): write failed detox tests (to reproduce wix#2834).

f33927a

Failed test: `scroll interactions -> should not be intractable when overlay is shown`.

asafkorem added a commit to asafkorem/Detox that referenced this issue Nov 29, 2021

fix(UIScrollView+DetoxActions): assert on interaction when view is no…

dd28a56

…t visible. This fixes the bug reported on this issue: wix#2834.

asafkorem added a commit to asafkorem/Detox that referenced this issue Nov 29, 2021

fix(UIScrollView): assert on interaction when view is hidden.

3124c1a

This fixes the bug reported on this issue: wix#2834.

asafkorem mentioned this issue Nov 29, 2021

fix(scrollTo): raise if scroll view element is not hittable. #3115

Merged

asafkorem linked a pull request Nov 29, 2021 that will close this issue

fix(scrollTo): raise if scroll view element is not hittable. #3115

Merged

asafkorem added a commit to asafkorem/Detox that referenced this issue Nov 29, 2021

fix(UIScrollView): assert on interaction when view is not hittable.

3ebd8cf

This fixes the bug reported on this issue: wix#2834.

asafkorem added a commit to asafkorem/Detox that referenced this issue Nov 29, 2021

iOS(Test App): write failed detox tests (to reproduce wix#2834).

30a1ef0

Failed test: `scroll interactions -> should not be intractable when overlay is shown`.

asafkorem added a commit to asafkorem/Detox that referenced this issue Nov 29, 2021

fix(UIScrollView): assert on scrolling when view is not visible.

6a5fc38

This fixes the bug reported on this issue: wix#2834.

asafkorem added a commit that referenced this issue Dec 6, 2021

iOS(Test App): write failed detox tests (to reproduce #2834).

b78b551

Failed tests: - `scroll view -> should not be scrollable when overlay is shown`. - `button -> should not be hittable when overlay is shown`.

asafkorem closed this as completed in #3115 Dec 6, 2021

asafkorem mentioned this issue Dec 27, 2021

Revert: is-hittable changes. #3150

Merged

d4vidi added status: triage type: bug 🐞 labels Apr 13, 2022

d4vidi added the bugathon label May 17, 2022

asafkorem mentioned this issue Oct 2, 2022

fix(iOS): revert^2 hittability-test mechanism fixes. #3620

Merged

asafkorem added a commit that referenced this issue Nov 7, 2022

fix(iOS): improve hittability-check mechanism. (#3620)

e1f66d1

This change reverts #3150, and adds the following changes (hit-test): - #3149 - #3145 - #3115 Those changes resolves this issue #2834.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interactive touch outside React-Native-Navigation Overlay when detox run #2834

Interactive touch outside React-Native-Navigation Overlay when detox run #2834

hqdai commented Jun 14, 2021 •

edited

Loading

noomorph commented Jun 18, 2021

stale bot commented Jul 18, 2021

stale bot commented Jul 25, 2021

hqdai commented Jul 29, 2021

d4vidi commented Aug 1, 2021

alon-ha commented Aug 8, 2021

stale bot commented Sep 7, 2021

phuongwd commented Sep 9, 2021

phuongwd commented Sep 9, 2021 •

edited

Loading

d4vidi commented Sep 9, 2021

phuongwd commented Sep 12, 2021 •

edited

Loading

stale bot commented Oct 12, 2021

phuongwd commented Oct 14, 2021

stale bot commented Nov 19, 2021

asafkorem commented Nov 29, 2021 •

edited

Loading

Interactive touch outside React-Native-Navigation Overlay when detox run #2834

Interactive touch outside React-Native-Navigation Overlay when detox run #2834

Comments

hqdai commented Jun 14, 2021 • edited Loading

Description

Reproduction

Environment:

noomorph commented Jun 18, 2021

stale bot commented Jul 18, 2021

stale bot commented Jul 25, 2021

hqdai commented Jul 29, 2021

d4vidi commented Aug 1, 2021

alon-ha commented Aug 8, 2021

stale bot commented Sep 7, 2021

phuongwd commented Sep 9, 2021

phuongwd commented Sep 9, 2021 • edited Loading

d4vidi commented Sep 9, 2021

phuongwd commented Sep 12, 2021 • edited Loading

stale bot commented Oct 12, 2021

phuongwd commented Oct 14, 2021

stale bot commented Nov 19, 2021

asafkorem commented Nov 29, 2021 • edited Loading

hqdai commented Jun 14, 2021 •

edited

Loading

phuongwd commented Sep 9, 2021 •

edited

Loading

phuongwd commented Sep 12, 2021 •

edited

Loading

asafkorem commented Nov 29, 2021 •

edited

Loading