Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main.jsbundle does not exist #1190

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix main.jsbundle does not exist #1190

merged 1 commit into from
Mar 27, 2019

Conversation

msand
Copy link
Contributor

@msand msand commented Mar 3, 2019

  • This is a small change

@msand msand requested a review from rotemmiz as a code owner March 3, 2019 18:03
@LeoNatan
Copy link
Contributor

I'm not sure I understand this change. Please explain.

@msand
Copy link
Contributor Author

msand commented Mar 27, 2019

On travis this is required to alias node to the correct node.js version, otherwise the packager fails to create the bundle, as it's calling the previously existing node instead.

@LeoNatan LeoNatan merged commit 9adfae8 into wix:master Mar 27, 2019
@LeoNatan
Copy link
Contributor

Merged, thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rotemmiz rotemmiz Awaiting requested review from rotemmiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msand @LeoNatan