Only generate methods with supported types #238
Conversation
DanielMSchmidt
force-pushed
the
generation/only-methods-with-supported-types
branch
2 times, most recently
from
52c3105
to
d00b2cc
Compare
| @param duration The duration of the long press. | ||
|
|
||
| @return A GREYAction that performs a long press on an element. | ||
| */static actionForLongPressWithDuration(duration) { |
There was a problem hiding this comment.
duration is CFTimeInterval === double, no need to kill it
There was a problem hiding this comment.
Great, I will add this to the list
There was a problem hiding this comment.
@rotemmiz I double checked it, it is not included in the switch statement in method invocation Therefore we need to remove it for now. I will add this functionality while extending MethodInvocation in the same manner. That way the commits are sane and make sense 👍
| @@ -196,60 +148,6 @@ starting from the given start points. | |||
| }; | |||
| } | |||
|
|
|||
| /*@return A GREYAction that scrolls to the given content @c edge of a scroll view. | |||
| */static actionForScrollToContentEdge(edge) { | |||
There was a problem hiding this comment.
edge is GREYContentEdge , an ENUM, returns an NSString
There was a problem hiding this comment.
I would like to sanitize these enums. As the sanitizer isn't build yet I excluded them. My next goal is to readd these functions
|
|
||
| @return A GREYAction that scrolls to the given content @c edge of a scroll view with the scroll | ||
| action starting from the given start point. | ||
| */static actionForScrollToContentEdgeXOriginStartPercentageYOriginStartPercentage(edge, xOriginStartPercentage, yOriginStartPercentage) { |
There was a problem hiding this comment.
Probably needs to be normalized like you did before
| 30 degrees). | ||
|
|
||
| @return A GREYAction that performs a fast pinch on the view in the specified @c direction. | ||
| */static actionForPinchFastInDirectionWithAngle(pinchDirection, angle) { |
| @param on The switch control state. | ||
|
|
||
| @return A GREYAction to toggle a UISwitch. | ||
| */static actionForTurnSwitchOn(on) { |
There was a problem hiding this comment.
yea, we have problems with bools
| @param column The UIPickerView column being set. | ||
| @param value The value to set the UIPickerView. | ||
|
|
||
| @return A GREYAction to set the value of a specified column of a UIPickerView. |
There was a problem hiding this comment.
This was 100% a mistake!
| @param date The date to set the UIDatePicker. | ||
|
|
||
| @return A GREYAction that sets a given date/time on a UIDatePicker. | ||
| */static actionForSetDate(date) { |
| @param duration The duration of the long press. | ||
|
|
||
| @return A GREYAction that performs a long press on an element. | ||
| */static actionForLongPressAtPointDuration(point, duration) { |
DanielMSchmidt
force-pushed
the
generation/only-methods-with-supported-types
branch
from
d00b2cc
to
e275e26
Compare
DanielMSchmidt
force-pushed
the
generation/only-methods-with-supported-types
branch
from
e275e26
to
71b6b4d
Compare
|
Added the tests and verified the comments you made. These functions should mostly be unsupported and I would add them together with the change in the iOS mapping in MethodInvocation as we add new functionality. <3 I would merge this as soon as I see the tests green, we can still make changes afterwards 👍 |
DanielMSchmidt
deleted the
generation/only-methods-with-supported-types
branch
We currently generate code that isn't supported by the detox client.
This causes confusion amongst developers adopting the generated code (see #228).