Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detox CLI: Jest integration fixes #423

Merged
merged 6 commits into from
Nov 23, 2017
Merged

Detox CLI: Jest integration fixes #423

merged 6 commits into from
Nov 23, 2017

Conversation

rotemmiz
Copy link
Member

Fixed jest integration issues

Niryo and others added 5 commits November 21, 2017 16:36
@Niryo
added runner-config
1529a0f
@rotemmiz
cmd:
524a81b 
- no runner option

json config:
- runner config should be passed with relative path from root
@rotemmiz
exec permissions
37670fd
@Niryo
fixed tests
3bce188
@rotemmiz
updated build matrix
138e4a0
@rotemmiz rotemmiz mentioned this pull request Nov 21, 2017
Closed
@rotemmiz rotemmiz changed the title Jest cli integration fixes Detox CLI: Jest integration fixes Nov 21, 2017
@rotemmiz rotemmiz mentioned this pull request Nov 21, 2017
Closed
@rotemmiz rotemmiz changed the title Detox CLI: Jest integration fixes [BREAKING] Detox CLI: Jest integration fixes Nov 21, 2017
@LeoNatan
Copy link
Contributor

What is this breaking?

@rotemmiz
Copy link
Member Author

command line:

  • runner option has been removed, will only be available from json config in package.json

json config:

  • test-runner instead of runner
  • test-runner should be passed with relative path from root, will not join path with specs anymore.

@LeoNatan LeoNatan changed the title [BREAKING] Detox CLI: Jest integration fixes Detox CLI: Jest integration fixes Nov 23, 2017
@rotemmiz rotemmiz merged commit 81ba64b into master Nov 23, 2017
@rotemmiz rotemmiz mentioned this pull request Nov 27, 2017
Closed
@rotemmiz rotemmiz deleted the jest-cli-fixes branch December 24, 2017 10:06
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement ⚡️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rotemmiz @LeoNatan @Niryo