Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add device.tap() and device.longPress(). #4542

Merged
merged 5 commits into from
Nov 14, 2024
Merged

feat: add device.tap() and device.longPress(). #4542

merged 5 commits into from
Nov 14, 2024

Conversation

gayablau
Copy link
Contributor

@gayablau gayablau commented Aug 1, 2024 •
edited by d4vidi
Loading

Description

In this pull request, I have added api for device tap and long press for android and IOS
fixed review comments in #4534

For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@gayablau gayablau changed the base branch from master to feat/device-tap August 1, 2024 07:24
@gayablau gayablau changed the title Feat device.tap() ios feat: add device.tap() and device.longPress(). Sep 7, 2024
@gayablau gayablau mentioned this pull request Sep 7, 2024
Closed
2 tasks
@gayablau gayablau changed the base branch from feat/device-tap to master September 7, 2024 08:42
@gayablau gayablau marked this pull request as ready for review September 7, 2024 09:31
@gayablau gayablau requested a review from gosha212 September 8, 2024 06:19
@asafkorem asafkorem self-assigned this Sep 11, 2024
@asafkorem
Copy link
Contributor

Unit test failed due to code coverage issues.
@gayablau please make sure your tests cover the following lines (or remove them if they are dead-codes).

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
invocationTraceDescriptions.js 98.07 93.33 98.03 98.07 6
mapDeviceLongPressArguments.js 91.66 94.44 100 91.66 34-36

asafkorem
asafkorem requested changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@asafkorem asafkorem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively small comments compared to this massive, impressive, awesome work. This is REALLY great work, @gayablau. 100 / 100! 🫡 We are close!

detox/android/detox/src/full/java/com/wix/detox/espresso/EspressoDetox.java Outdated Show resolved Hide resolved
detox/android/detox/src/full/java/com/wix/detox/espresso/UiAutomatorHelper.java Outdated Show resolved Hide resolved
detox/ios/DetoxXCUITestRunner/DetoxXCUITestRunner/Handlers/ActionHandler.swift Outdated Show resolved Hide resolved
detox/ios/DetoxXCUITestRunner/DetoxXCUITestRunner/Handlers/ActionHandler.swift Outdated Show resolved Hide resolved
detox/ios/DetoxXCUITestRunner/DetoxXCUITestRunner/Handlers/ActionHandler.swift Outdated Show resolved Hide resolved
detox/ios/DetoxXCUITestRunner/DetoxXCUITestRunner/Handlers/ActionHandler.swift Outdated Show resolved Hide resolved
docs/api/device.md Outdated Show resolved Hide resolved
@asafkorem
Copy link
Contributor

missing unit tests (see coverage phase). should be simple ones

@asafkorem asafkorem merged commit b4554de into master Nov 14, 2024
7 checks passed
@asafkorem asafkorem deleted the feat/device-tap-ios branch November 14, 2024 18:21
@asafkorem
Copy link
Contributor

Released with 20.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafkorem asafkorem asafkorem approved these changes

Assignees

@asafkorem asafkorem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce device.tap(point), device.longPress(point) API's
2 participants
@gayablau @asafkorem