Skip to content

Commit

Permalink
feat(core): re-set sideEffects: false, remove last side effect import
Browse files Browse the repository at this point in the history
- safari now supports web worker initialized from another web worker
- import is happening anyway in code that imports Worker from @wixc3/isomorphic-worker/worker
  • Loading branch information
AviVahl committed Dec 15, 2024
1 parent 2dd2bc7 commit 9dfc899
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
3 changes: 2 additions & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,6 @@
"license": "MIT",
"publishConfig": {
"access": "public"
}
},
"sideEffects": false
}
5 changes: 0 additions & 5 deletions packages/core/src/run-engine-app.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
/**
* Extends globalThis.Worker with a polyfill for web workers in safari.
*/
import '@wixc3/isomorphic-worker/worker';

import { RuntimeEngine } from './runtime-engine.js';
import type { IRunOptions, TopLevelConfig } from './types.js';
import type { AnyEnvironment, FeatureClass } from './entities/index.js';
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-node/src/metrics-utils.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { PerformanceMetrics } from './types.js';
import type { ChildProcess } from 'node:child_process';
import { Worker } from '@wixc3/isomorphic-worker/worker';
import type { Worker } from '@wixc3/isomorphic-worker/worker';
import { isValidRpcResponse, rpcCall, getNextMessageId, bindRpcListener } from './micro-rpc.js';

export function bindMetricsListener(
Expand Down

0 comments on commit 9dfc899

Please sign in to comment.