chore(deps): socket.io@4.8.0, esbuild@0.24.0

- adjust socket.io code to close returning a promise now - regenerate lock file
wixplosives · Sep 22, 2024 · a7ba76f · a7ba76f
1 parent cace2be
commit a7ba76f
Show file tree

Hide file tree

Showing 11 changed files with 142 additions and 143 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -56,7 +56,7 @@
     "chai": "^4.5.0",
     "chai-as-promised": "^7.1.2",
     "create-temp-directory": "^2.4.0",
-    "esbuild": "^0.23.1",
+    "esbuild": "^0.24.0",
     "eslint": "^9.11.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-no-only-tests": "^3.3.0",

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -21,7 +21,7 @@
     "@wixc3/isomorphic-worker": "^1.2.5",
     "@wixc3/patterns": "^17.1.1",
     "promise-assist": "^2.0.1",
-    "socket.io-client": "^4.7.5",
+    "socket.io-client": "^4.8.0",
     "typescript-type-utils": "^0.1.0"
   },
   "files": [

diff --git a/packages/engine-cli/package.json b/packages/engine-cli/package.json
@@ -28,7 +28,7 @@
     "express": "^4.21.0",
     "is-ci": "^3.0.1",
     "promise-assist": "^2.0.1",
-    "socket.io": "^4.7.5"
+    "socket.io": "^4.8.0"
   },
   "files": [
     "dist",

diff --git a/packages/engine-cli/src/start-dev-server.ts b/packages/engine-cli/src/start-dev-server.ts
@@ -52,11 +52,10 @@ export async function launchServer({
         transports: ['websocket'],
     });
 
-    const close = () =>
-        new Promise<void>((res, rej) => {
-            httpServer.closeAllConnections();
-            socketServer.close((e) => (e ? rej(e) : res()));
-        });
+    const close = async () => {
+        httpServer.closeAllConnections();
+        await socketServer.close();
+    };
 
     return {
         close,

diff --git a/packages/engineer/package.json b/packages/engineer/package.json
@@ -38,7 +38,7 @@
     "commander": "^12.1.0",
     "express": "^4.21.0",
     "open": "^8.4.2",
-    "socket.io": "^4.7.5",
+    "socket.io": "^4.8.0",
     "webpack-dev-middleware": "^7.4.2"
   },
   "files": [

diff --git a/packages/runtime-node/package.json b/packages/runtime-node/package.json
@@ -20,7 +20,7 @@
     "create-listening-server": "^2.1.0",
     "express": "^4.21.0",
     "minimist": "^1.2.8",
-    "socket.io": "^4.7.5"
+    "socket.io": "^4.8.0"
   },
   "files": [
     "dist",

diff --git a/packages/runtime-node/src/launch-http-server.ts b/packages/runtime-node/src/launch-http-server.ts
@@ -61,10 +61,8 @@ export async function launchEngineHttpServer({
 
     return {
         close: async () => {
-            await new Promise<void>((res, rej) => {
-                httpServer.closeAllConnections();
-                socketServer.close((e) => (e ? rej(e) : res()));
-            });
+            httpServer.closeAllConnections();
+            await socketServer.close();
         },
         port,
         app,

diff --git a/packages/runtime-node/src/node-environments-manager.ts b/packages/runtime-node/src/node-environments-manager.ts
@@ -438,7 +438,7 @@ export class NodeEnvironmentsManager {
                     ).start();
                     close = wsEnvClose;
                 } catch (e) {
-                    await new Promise<void>((res, rej) => socketServer.close((e) => (e ? rej(e) : res())));
+                    await socketServer.close();
                     throw e;
                 }
                 const openSockets = new Set<Socket>();
@@ -457,7 +457,7 @@ export class NodeEnvironmentsManager {
                         for (const socket of openSockets) {
                             socket.destroy();
                         }
-                        await new Promise<void>((res, rej) => socketServer.close((e) => (e ? rej(e) : res())));
+                        await socketServer.close();
                         await close();
                     },
                 };

diff --git a/packages/runtime-node/test/node-com.unit.ts b/packages/runtime-node/test/node-com.unit.ts
@@ -39,7 +39,7 @@ describe('Socket communication', () => {
         const nameSpace = socketServer.of('processing');
         serverTopology['server-host'] = `http://localhost:${port}/processing`;
         const connections = new Set<Socket>();
-        disposables.add('socketServer.close', () => new Promise((res) => socketServer.close(res)));
+        disposables.add('socketServer.close', () => socketServer.close());
         disposables.add('reset serverTopology', () => (serverTopology = {}));
         const onConnection = (connection: Socket): void => {
             connections.add(connection);
@@ -231,7 +231,7 @@ describe('Socket communication', () => {
         expect(onDisconnect).to.not.eq(undefined);
 
         onDisconnect(spy);
-        socketServer.close();
+        await socketServer.close();
         await waitFor(
             () => {
                 expect(spy.callCount).to.be.eq(1);
@@ -328,7 +328,9 @@ describe('IPC communication', () => {
         const { waitForCall, spy } = createWaitForCall<(e: Error) => void>();
         proxy.echo().catch(spy);
         await waitForCall((args) => {
-            expect(args[0].message).to.have.string('Remote call failed in "process" - environment disconnected at "main"');
+            expect(args[0].message).to.have.string(
+                'Remote call failed in "process" - environment disconnected at "main"',
+            );
         });
     });
 });
diff --git a/packages/scripts/package.json b/packages/scripts/package.json
@@ -29,7 +29,7 @@
     "create-listening-server": "^2.1.0",
     "express": "^4.21.0",
     "semver": "^7.6.3",
-    "socket.io": "^4.7.5",
+    "socket.io": "^4.8.0",
     "type-fest": "^4.26.1"
   },
   "files": [