fix: added reportError polyfil #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisey
reviewed
Dec 7, 2023
| @@ -1,3 +1,5 @@ | |||
| import "./polyfills/report-error-polyfill.js"; | |||
There was a problem hiding this comment.
No need for it in web workers?
There was a problem hiding this comment.
no, I verified that this entrypoint is run for any type of environment, including webworker
alisey
reviewed
Dec 7, 2023
Comment on lines
3
to
7
| /** | ||
| * hope this is single polyfill we need for now | ||
| * in case if more will be added, we need to create some | ||
| * better mechanism to handle polyfills | ||
| */ |
There was a problem hiding this comment.
/**
* This polyfill is not essential for the engine itself. But applications built
* on the engine may require this polyfill to correctly report initialization
* errors in older browsers.
* Ideally, the engine should offer a mechanism allowing applications to
* initialize necessary polyfills before the evaluation of feature files begins.
* But so far we only need this single polyfill.
*/
alisey
approved these changes
Dec 7, 2023
|
I'm removing this, as this stops the engine-core package from having no side effects. We need to find a better way to inject polyfills needed by applications. As a replacement to this change, I'm changing engine-core's |
AviVahl
added a commit
that referenced
this pull request
Dec 15, 2024
reverts #2192 to remove only sideEffect in engine-core package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reportError polyfill to allow applications and are using native
reportErrorto execute feature setup.