Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow passing entry options via script query #2500

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

zetmate
Copy link
Contributor

@zetmate zetmate commented Jun 20, 2024

For the abomination. Providing entry options by other means than the search params will allow to keep the iframe url clean which is vital when running the full app instead of a board.

@zetmate zetmate requested a review from barak007 June 20, 2024 10:41
@zetmate zetmate changed the title Kate/allow passing entry options via script query feat: allow passing entry options via script query Jun 20, 2024
@zetmate zetmate changed the title feat: allow passing entry options via script query feat(core): allow passing entry options via script query Jun 20, 2024
packages/core/src/helpers/web.ts Outdated Show resolved Hide resolved
packages/core/src/runtime-configurations.ts Outdated Show resolved Hide resolved
@zetmate zetmate force-pushed the kate/allow-passing-entry-options-via-script-query branch from eaa9778 to 035cf22 Compare June 24, 2024 15:52
@zetmate zetmate requested a review from barak007 June 24, 2024 15:53
@zetmate zetmate merged commit 67552a7 into master Jun 25, 2024
6 checks passed
@zetmate zetmate deleted the kate/allow-passing-entry-options-via-script-query branch June 25, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants