feat: use node's native import() to load modules #2526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviVahl
force-pushed
the
avi/use-node16-module
branch
2 times, most recently
from
57366c5 to
24caf98
Compare
|
BTW |
AviVahl
force-pushed
the
avi/use-node16-module
branch
from
24caf98 to
9275570
Compare
AviVahl
force-pushed
the
avi/use-node16-module
branch
4 times, most recently
from
7553cb4 to
516ed0c
Compare
AviVahl
force-pushed
the
avi/use-node16-module
branch
2 times, most recently
from
9da3810 to
8f67a3d
Compare
|
This didn't land as using dynamic import requires registration of a loader if you run directory from sources. |
AviVahl
force-pushed
the
avi/use-node16-module
branch
2 times, most recently
from
eae54db to
75fb030
Compare
AviVahl
force-pushed
the
avi/use-node16-module
branch
from
75fb030 to
a73bb38
Compare
AviVahl
force-pushed
the
avi/use-node16-module
branch
from
a73bb38 to
aea72ec
Compare
target is now node16, which means we still transpile our code to cjs (no "type": "module" yet). we now retain the dynamic import() calls as-is, rather than transpiling them to require() calls. this will make it easier for user projects to move to native esm.
AviVahl
force-pushed
the
avi/use-node16-module
branch
from
aea72ec to
94d4498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target is now node16, which means we still transpile our code to cjs (no "type": "module" yet).
we now retain the dynamic import() calls as-is, rather than transpiling them to require() calls.
this will make it easier for user projects to move to native esm.