Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(communication): better communication errors #2568

Merged
merged 2 commits into from
Sep 12, 2024
Merged

refactor(communication): better communication errors #2568

merged 2 commits into from
Sep 12, 2024

Conversation

plisovyi
Copy link
Contributor

  1. cleanMessageForLog helper moved to helpers.ts to be reused both in debug logging of communication.ts and communication error creation
  2. renamed environment-disconnected-error.ts to communication-errors.ts and implemented inside base communications error class and custom classes for better messaging and potential to sort through errors in error monitoring solutions.

@plisovyi plisovyi marked this pull request as ready for review September 12, 2024 10:45
@barak007
Copy link
Collaborator

much better

@plisovyi plisovyi mentioned this pull request Sep 12, 2024
Closed
@plisovyi plisovyi merged commit 63a92cd into master Sep 12, 2024
6 checks passed
@plisovyi plisovyi deleted the pavlo/just-only-errors branch September 12, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barak007 barak007 barak007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plisovyi @barak007