Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support css selector nesting syntax #17

Merged
merged 5 commits into from
Jun 28, 2021
Merged

support css selector nesting syntax #17

merged 5 commits into from
Jun 28, 2021

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Jun 27, 2021 •
edited
Loading

This PR add the nesting selector.

  • new nesting ast type: { type: "nesting", value: "&", nodes: [] }
  • support non native inner nodes: &(a, b)

@idoros idoros added the enhancement New feature or request label Jun 27, 2021
@idoros idoros requested a review from barak007 June 27, 2021 13:08
barak007
barak007 requested changes Jun 28, 2021
View reviewed changes
Copy link
Collaborator

@barak007 barak007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more tests for that.

.z&div
[&="&"]
&&
&(:hover)
&|&

@idoros
Copy link
Collaborator Author

idoros commented Jun 28, 2021

added, the last &|& is nesting, element with no type or namespace, nesting...

@idoros idoros merged commit 8ad2f9d into master Jun 28, 2021
@idoros idoros deleted the ido/css-selector-nesting branch June 28, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barak007 barak007 barak007 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idoros @barak007