Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(selector-parser): lost of first non space of a descendant combinator #288

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Dec 8, 2022

This PR fixes an issue for descendant selectors that start with a non space character, like newline.

Before this fix the combinator node would be build with with a space character as the value and after that includes any additional characters after the first one.

for example:

.a/*newline+space+newline*/

.b {}

would output a descendant combinator with {value: , after: \n }, losing the initial newline.

@idoros idoros added bug Something isn't working css-selector-parser labels Dec 8, 2022
@idoros idoros requested a review from barak007 December 8, 2022 10:56
@idoros idoros self-assigned this Dec 8, 2022
@idoros idoros merged commit b215e38 into master Dec 14, 2022
@idoros idoros deleted the ido/fix-descendant-non-space-combinator branch December 14, 2022 12:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working css-selector-parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants