Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(selector-parser): normalize names #34

Merged
merged 3 commits into from
Jul 19, 2021
Merged

change(selector-parser): normalize names #34

merged 3 commits into from
Jul 19, 2021

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Jul 19, 2021

This PR changes the AST type names and type fields to be a bit closer to the spec

  • Element selector --> Type selector
  • Star selector --> Universal selector
  • Containers --> Functional selector

@idoros idoros requested a review from barak007 July 19, 2021 08:33
barak007
barak007 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@barak007 barak007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's wired for me to see that element is called type.

@idoros idoros merged commit 1f541ea into master Jul 19, 2021
@idoros idoros deleted the ido/css-selecor-normalize-names branch July 19, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barak007 barak007 barak007 approved these changes

Assignees
No one assigned
Labels
css-selector-parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idoros @barak007