Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design - permissionPopover #117

Open
8 tasks done
Tracked by #111
Mehrabbruno opened this issue Sep 7, 2022 · 3 comments
Open
8 tasks done
Tracked by #111

Design - permissionPopover #117

Mehrabbruno opened this issue Sep 7, 2022 · 3 comments

Comments

@Mehrabbruno
Copy link
Collaborator

Mehrabbruno commented Sep 7, 2022

@todo

#112

@info

This pop-over is designed for to be placed in component tab_v0.0.1

@Mehrabbruno Mehrabbruno mentioned this issue Sep 7, 2022
5 tasks
@Mehrabbruno Mehrabbruno changed the title Design - permissionPopover_v0.0.1 pop-over for tabsContainer_v0.0.1 Design - permissionPopover_v0.0.1 pop-over for tab_v0.0.1 Sep 7, 2022
@Mehrabbruno Mehrabbruno changed the title Design - permissionPopover_v0.0.1 pop-over for tab_v0.0.1 Design - permissionPopover Sep 18, 2022
@Mehrabbruno
Copy link
Collaborator Author

Mehrabbruno commented Oct 4, 2022

Worklog

Worklog 1 2022.10.21


Tasks

  • done Design - Permission pop-over (toggles on onClick) - 1min
    • done permissionPopover (contains) - 1min
      • done pop-over header (fixed to the top and contains title, total number of permissions and close button) - 1min
      • done Permission container (contains checkboxes with labels) - 1min
      • done Search input (contains search icon, inputField and close icon when added text) - 1min
      • done Record an explanatory video for permissionPopover and add it in the header description - 1min
      • @output 📦 permissionPopover_v0.0.1

@serapath
Copy link
Member

feedback 2022.10.14

same again as always :-)

  1. missing worklog video link in worklog comment above
  2. missing times after each done task

regarding permission popover - we need to refine this a lot.
Basically what this is about is granting permissions to the app to read one or more files from the users file explorer, therefore the popover should probably look a lot more like the file explorer, maybe we can even re-use the file explorer component and literally allow the user to mark for each file/folder whether the app has permissions to create/read/write/delete/change? ...etc that file :-)

Or maybe the user selects files or folders and chooses permissions and then it gets added to the list of permissions to that app and file?

Or maybe for re-usability or whatever we show the file explorer anf just highlight all the files/folder where permissions are granted?

important: because we might need the file explorer for this section, we should maybe FIRST finish the file explorer and then use that as yet another @input for this component, which also means we have to refine and improve the file explorer first :-)

@Mehrabbruno
Copy link
Collaborator Author

Mehrabbruno commented Oct 30, 2022

Worklog

worklog-1 2022.10.31


Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants