Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design - actionsPopover #118

Open
8 tasks done
Tracked by #111
Mehrabbruno opened this issue Sep 7, 2022 · 7 comments
Open
8 tasks done
Tracked by #111

Design - actionsPopover #118

Mehrabbruno opened this issue Sep 7, 2022 · 7 comments

Comments

@Mehrabbruno
Copy link
Collaborator

Mehrabbruno commented Sep 7, 2022

@info

This pop-over is designed for to be placed in component tab_v0.0.1

@todo

#112

@Mehrabbruno Mehrabbruno mentioned this issue Sep 7, 2022
5 tasks
@Mehrabbruno Mehrabbruno changed the title Design - actionsPopover_v0.0.1 pop-over for tabsContainer_v0.0.1 Design - actionsPopover_v0.0.1 pop-over for tab_v0.0.1 Sep 7, 2022
@Mehrabbruno Mehrabbruno changed the title Design - actionsPopover_v0.0.1 pop-over for tab_v0.0.1 Design - actionsPopover Sep 18, 2022
@Mehrabbruno
Copy link
Collaborator Author

Mehrabbruno commented Oct 4, 2022

Worklog

Worklog 1 2022.10.21


Tasks

  • done Design - Actions pop-over (toggles on onClick). it contians: - 1min
    • done pop-over header (fixed to the top and contains title, total number of actions and close button) - 1min
    • done Actions container (contains action title) - 1min
    • done Search input (contains search icon, inputField and close icon when added text) - 1min
    • done Record an explanatory video for actionsPopover_v0.0.1 and add it in the header description - 1min

Proposal


Feedback

@serapath
Copy link
Member

feedback 2022.10.14

same again

  1. needs worklog video in above worklog comment
  2. needs times logged behind each task

otherwise, the component is great and can stay as it is :-)

@serapath
Copy link
Member

feedback 2022.10.22

one feature missing from the actions popover is that each action should have the option to display/edit the keyboard shortcust that can trigger that action while the focus is on the tab/tile of the active program. Basically keyboard shortcust here are dependent on which program tab is currently active.

@Mehrabbruno
Copy link
Collaborator Author

feedback 2022.10.24

each action should have the option to display/edit the keyboard shortcust

How will the editing that action work? will that edit be applied on that specific tab or all the places? Where the user can edit the shortcuts? directly from that action? If so, isn’t the click-able(action) button gonna be small? since that action button itself could be quite small.

How about we add the edit action button on that popover itself?

@serapath
Copy link
Member

feedback 2022.10.26

all actions are specific to a program
If action keyboard shortcuts are edited, they apply everywhere where a tab uses the same program.

I assume the keyboard shortcut could be displayed behind the action name and clicking the shortcut turns it into an input field or something for a user to press/choose different keyboard shortcut.

Keyboard shortcuts have hierarchy, so the TWM or tab which opens the program might have some keyboard shortcuts and the program cannot override those and would display a keyboard shortcut is already in use.

if we have the clickable action button whatever the action button does should be changable/definable form the select action popover

The only thing that can be edited is the keyboard shortcut of an action, nothing else.

@Mehrabbruno
Copy link
Collaborator Author

Mehrabbruno commented Oct 30, 2022

Tasks


Worklog

worklog - 72


Proposal


Feedback

@serapath
Copy link
Member

feedback 2022.10.31

When you open a program like figma it wont show you all the actions you can do when you open vscode.

So the action popover will read all the available action from the program that is open.
Each program that we create will provide some actions to the action popover to be displayed.

There is no way we can always show all actions that are possible with any program.

Which shortcut keys are active depends on the program tile in focus and what action it's program supports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants