Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui: double check change addresses #841

Closed
darosior opened this issue Nov 29, 2023 · 0 comments · Fixed by #938
Closed

gui: double check change addresses #841

darosior opened this issue Nov 29, 2023 · 0 comments · Fixed by #938
Assignees
@edouardparis
Labels
Enhancement Improving an existing functionality GUI gui related

Comments

@darosior
Copy link
Member

Currently the GUI assumes any PSBT output with its bip32_derivation set is a change output. It should also check the address matches the one for our descriptor at this derivation.
@darosior darosior added GUI gui related Enhancement Improving an existing functionality labels Nov 29, 2023
@darosior darosior mentioned this issue Dec 7, 2023
Closed
@darosior darosior moved this to Todo in Liana v5 Dec 11, 2023
@edouardparis edouardparis self-assigned this Jan 25, 2024
@edouardparis edouardparis moved this from Todo to In Progress in Liana v5 Jan 25, 2024
@edouardparis edouardparis mentioned this issue Jan 25, 2024
Merged
edouardparis added a commit that referenced this issue Jan 26, 2024
@edouardparis
Merge #938: gui: use descriptor method to detect psbt change outputs
a34070d 
366e9b7 gui: use descriptor method to detect psbt change outputs (edouardparis)

Pull request description:

  This commit also fix handling of create_spend result while updating liana:master

  close #841

ACKs for top commit:
  edouardparis:
    Self-ACK 366e9b7

Tree-SHA512: 5316e610ec6fe1c09447329c031a52710fa7802c0135cc2e386d9926d5f189f1b381596b1f5b081beb2904341d4d7468fa1b4148e9fc49644670e5d8335ca015
@edouardparis edouardparis moved this from In Progress to Done in Liana v5 Jan 29, 2024
pythcoiner pushed a commit to pythcoiner/liana that referenced this issue Jan 29, 2024
@edouardparis
gui: use descriptor method to detect psbt change outputs
f1fcf26 
This commit also fix handling of create_spend result while
updating liana:master

close wizardsardine#841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edouardparis edouardparis

Labels
Enhancement Improving an existing functionality GUI gui related
Projects
No open projects
Liana v5
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gui: use descriptor method to detect psbt change outputs edouardparis/liana
2 participants
@edouardparis @darosior