Add derivation_index to GetAddressResult #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparis
force-pushed
the
add-derivation_index-getaddress-response
branch
from
5927c22 to
9da27de
Compare
edouardparis
force-pushed
the
add-derivation_index-getaddress-response
branch
from
9da27de to
b6a8e56
Compare
darosior
reviewed
Nov 16, 2023
darosior
force-pushed
the
add-derivation_index-getaddress-response
branch
from
b6a8e56 to
b724aa5
Compare
|
It's missing a doc update. Will push that shortly. |
darosior
force-pushed
the
add-derivation_index-getaddress-response
branch
from
b724aa5 to
2e2afc1
Compare
|
ACK 2e2afc1 |
|
WTF |
|
My bad |
darosior
added a commit
that referenced
this pull request
Nov 16, 2023
33384c8 Add derivation_index to GetAddressResult (edouardparis) Pull request description: My bad, i pushed my fixes in a rush in #815 and wrecked the PR. ACKs for top commit: darosior: ACK 33384c8 Tree-SHA512: 5f18506a84ff10fbe13757c2522b11a7ec005243f8698425f1d761d4b36378c256150d3d8337fefc1938232990004bbd629878b42b032b1dd0349d593a39386d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The derivation index is required for
for client to derive and verify the address
on hardware wallets.