Verify receive address

[edouardparis]

No description provided.

[darosior]

A rebase on master would fix the CI, i think. (See #824.)

[darosior]

I don't know if it has anything to do with the implementation here, but after verifying the address on my Ledger Nano S (not plus) my Ledger's screen stay stuck on "Approve". Trying again unstucks it but it gets stuck again after i approved it. Same with "Reject".

[darosior]

If i trigger an error (reject the verification or otherwise disconnect the Ledger) it doesn't get cleaned up after i try again and approve the address.

UPDATE: screenshot removed for privacy

[edouardparis]

rebased on master to satisfy the ci

[darosior]

This looks great! 🚀

[edouardparis]

fixed the two comments and rebase, I do not know for the Ledger Nano.

[Rob1Ham]

I don't know if it has anything to do with the implementation here, but after verifying the address on my Ledger Nano S (not plus) my Ledger's screen stay stuck on "Approve". Trying again unstucks it but it gets stuck again after i approved it. Same with "Reject".

For what it is worth, I've seen this issue as well using the javascript library as well.

[darosior]

Good to know.

[darosior]

cc @bigspider: the above two comments may be of interest to you.

[darosior]

Tested this on a mainnet wallet with a Ledger Nano S. Looks good to me. Will now ask @jp1ac4 to have a look at the code.

[bigspider]

cc @bigspider: the above two comments may be of interest to you.

Please let me know how I can try to reproduce (e.g. policy and PSBT you were signing) and I'll give this a look ASAP

[jp1ac4]

utACK e9a217b.

As well as reviewing the code, I checked the receive screen, but did not verify any addresses on a device.

[darosior]

@edouardparis i trust you tested this with Bitbox and the Nano S+?