lamba_chunk_video: Implemented the video chunk lambda and stack. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viento
approved these changes
Jul 29, 2024
juanjoasensio-wizeline
approved these changes
Jul 29, 2024
| logger = logging.getLogger() | ||
| logger.setLevel(logging.INFO) | ||
| logger.info('event parameter: {}'.format(event)) | ||
| tmp_file_path = "/tmp/video.mp4" |
There was a problem hiding this comment.
Could this generate a collision if two lambdas were executed at the same time?
Suggested change
| tmp_file_path = "/tmp/video.mp4" | |
| import uuid | |
| tmp_file_path = "/tmp/video_" + uuid.uuid4().hex + ".mp4" |
There was a problem hiding this comment.
Hi @juanjoasensio-wizeline,
As far as I know the /tmp folder is local to the lambda execution, so I think there is no issue with that.
@CesarReyes Please let me know in case I am wrong.
CesarReyes
reviewed
Jul 29, 2024
| }); | ||
|
|
||
| // Import the Raw Videos Bucket using its name | ||
| const rawVideosBucketName = cdk.Fn.importValue('CommonRawVideosBucketName'); |
There was a problem hiding this comment.
Make sure you have the right lantern/indentation setup in your code editor, usually for TypeScript is two spaces
There was a problem hiding this comment.
Hi @CesarReyes,
The indentation issue, was created when I pushed my changes.
This is how it looks on my VSCode:
juanjoasensio-wizeline
force-pushed
the
feat/lambda_chunk_video
branch
from
00950cf
to
f5961a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the chunk_video lambda and stack.
I was not able to find the way for adding the keys and values I need, on the event used to run the lambda on the stack, so please @CesarReyes take a look of it and if you can explain us how to do it it will be highly appreciated.
@ehdez-wizeline found the possibility of passing the values over the environment:
const dockerFunction = new lambda.DockerImageFunction(this, 'VideoChunkDockerFunction', { functionName: 'VideoChunkDockerFunction', code: lambda.DockerImageCode.fromImageAsset('../../../source/video_chunk_lambda'), memorySize: 1024, timeout: cdk.Duration.minutes(10), architecture: lambda.Architecture.ARM_64, environment: { SECRETS_NAME: CommonSecret.secretName, BUCKET_NAME: YOUR_BUCKET_NAME, ... } });So maybe we can forget about the event object for that an modify the lambda to get the environment values for that purpose.
So please let us know what do you think about that as well.