-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast member pointer arguments of class_<T>::def() to member-of-T #471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been negative about this particular change in the past because I felt it adds too much boilerplate + templates that have to be instantiated for every function binding. I am not totally opposed but mainly interested in finding a simple and efficient solution.
5f632d6
to
5d83a83
Compare
Thanks for encouraging me to simplify this. Please take another look; I think you'll be much happier with the second version. It should work on anything that |
Yes, I am much happier with this version, thank you for making the changes. This looks good to merge to me, shall I? |
Go for it - thank you! |
Sorry, one more request: could you add a changelog entry? |
I think that the issue in #284 is also simplified by this commit. |
5d83a83
to
94b958c
Compare
Added changelog entry. |
Thank you 👍 |
Fixes #470; see that issue for a more detailed explanation of the problem. This ports over pybind's solution with some C++ modernization.