Rename forward_like
to avoid conflict with STL
#475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nanobind user code enables C++23, I found that
nanobind::detail::forward_like
has a naming conflict withstd::forward_like
in STL due to ADL.The situation is like this:
In particular, this will potentially occur when casting std object to a Python object using the nanobind STL caster.
The simplest solution is to rename
forward_like
(in this PR). We can also avoid ADL in other ways.