Special forms for nb::typed #835
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oremanj
force-pushed
the
typed-object
branch
from
57c6a91 to
6554c4b
Compare
oremanj
force-pushed
the
typed-object
branch
from
6554c4b to
e120400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two special forms for
nb::typed:nb::typed<nb::object, T>andnb::typed<nb::handle, T>render as justT, instead of the nonsensicalobject[T]that they would be otherwise. This allows recapture of the pre-2.0 functionality ofnb::typedwhere it entirely replaces (rather than augments) the type of an argument.nb::typed<nb::callable, Sig>for some C++ function signatureSigproduces an equivalent Python callable signature. For example,nb::typed<nb::callable, void(float, bool)>would becomeCallable[[int, float], None], which there is currently no way to express due to the nested brackets.