Merge branch 'fix/92'

wjdp · Sep 7, 2018 · d7bc545 · d7bc545
2 parents db89f38 + 39662b0
commit d7bc545
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/htmltest/check-meta.go b/htmltest/check-meta.go
@@ -28,6 +28,15 @@ func (hT *HTMLTest) checkMetaRefresh(document *htmldoc.Document, node *html.Node
 		// Define ref from this
 		var ref *htmldoc.Reference
 		if len(contentSplit) == 2 {
+			if contentSplit[1][0]==34 || contentSplit[1][0]==39 {
+				hT.issueStore.AddIssue(issues.Issue{
+					Level:     issues.LevelError,
+					Message:   "url in meta refresh must not start with single or double quote",
+					Reference: ref,
+				})
+				return
+			}
+
 			ref = htmldoc.NewReference(document, node, contentSplit[1])
 		} else {
 			ref = htmldoc.NewReference(document, node, "")

diff --git a/htmltest/check-meta_test.go b/htmltest/check-meta_test.go
@@ -83,3 +83,10 @@ func TestMetaRefreshContentInvalid(t *testing.T) {
 	tExpectIssueCount(t, hT3, 1)
 	tExpectIssue(t, hT3, "invalid content attribute in meta refresh", 1)
 }
+
+// Fails when meta refresh url starts with a single or double quote
+func TestIssue92(t *testing.T) {
+	hT := tTestFile("fixtures/meta/issues/92.html")
+	tExpectIssueCount(t, hT, 2)
+	tExpectIssue(t, hT, "url in meta refresh must not start with single or double quote", 2)
+}
diff --git a/htmltest/fixtures/meta/issues/92.html b/htmltest/fixtures/meta/issues/92.html
@@ -0,0 +1,8 @@
+<!doctype html>
+<html lang="en">
+<head>
+    <title>ox-hugo Test Site</title>
+    <meta http-equiv="refresh" content="0; URL='https://github.com/kaushalmodi/ox-hugo/issues'" />
+    <meta http-equiv="refresh" content='0; URL="https://github.com/kaushalmodi/ox-hugo/issues"' />
+</head>
+</html>