Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreAltMissing does not work with .htmltest #115

Closed
Merovex opened this issue Mar 28, 2019 · 9 comments
Closed

ignoreAltMissing does not work with .htmltest #115

Merovex opened this issue Mar 28, 2019 · 9 comments

Comments

@Merovex
Copy link

Merovex commented Mar 28, 2019

The feature ignoreAltMissing does not accept a true value when using the .htmltest feature

DirectoryPath: "public"
EnforceHTTPS: true
CacheExpires: "6h"
OutputLogFile: htmltest.log
LogLevel: 3
IgnoreAltMissing: false
CheckInternal: false
@wjdp
Copy link
Owner

wjdp commented Apr 1, 2019

Hi @Merovex, can you explain a little more?

  • What version of htmltest are you using? (Run htmltest -v)
  • What operating system are you running?
  • What error (if any) do you see?
  • What behaviour were you expecting?
  • What behaviour do you get?

@Merovex
Copy link
Author

Merovex commented Apr 1, 2019

htmltest 0.10.1
2018-10-02T21:20:31Z

I had just installed it.

Mac Mohave

The behavior I expected was decorative images with empty alt-tags (<img ... alt="">) would be ignored. This complies with WCAG-2.0 AA when the graphic conveys no information.

The behavior I got was it identified all empty alt-tags.

@wjdp
Copy link
Owner

wjdp commented Apr 1, 2019

Ah I see, I don't think we can offer a solution for this as it's context dependant.

Your only option would be to disable this check and 'take responsibility' for checking the alt tags yourself.

@Merovex
Copy link
Author

Merovex commented Apr 1, 2019 via email

@wjdp
Copy link
Owner

wjdp commented Apr 3, 2019

Gotcha, tested and confirmed this. Fix is attached in the PR. May revisit this in the future with a more explicit IgnoreAltBlank setting if you still want to check for missing alts.

@Merovex
Copy link
Author

Merovex commented Apr 4, 2019

Coolness. I'm not the most GH savvy, is there any way to get the executable so I can move past 0.10.1?

@wjdp wjdp closed this as completed in #120 Apr 4, 2019
@wjdp
Copy link
Owner

wjdp commented Apr 4, 2019

Not on GitHub no, just the release builds here.

CI does upload master builds onto this website https://builds.htmltest.wjdp.uk (looks like Linux and osx builds only). I've just merged so new build should appear within 10 mins. You want to pick the v0.10.1 build with the biggest number at the end, check the dates on the files to be sure.

(Disclaimer: haven't checked the builds on that site for a long time)

@wjdp
Copy link
Owner

wjdp commented Apr 4, 2019

This is the one you want: https://builds.htmltest.wjdp.uk/v0.10.1-16-g893c0dd/

@Merovex
Copy link
Author

Merovex commented Apr 4, 2019

shakes fist

I was going to complain it didn't work...then I double checked to ensure the IgnoreAltMissing was set (I had reversed it to confirm something earlier).

Now I'm only getting the errors that matter.

Shame on you, being helpful, and productive and all. You'll get a reputation. :)

Thank you for the fast turn around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants