Add option: IgnoreExternalBrokenLinks
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 82.74% 83.27% +0.53%
==========================================
Files 20 20
Lines 1153 1160 +7
==========================================
+ Hits 954 966 +12
+ Misses 179 174 -5
Partials 20 20
Continue to review full report at Codecov.
|
|
@abhishalya Saw your issue this morning. We've this exact problem on a site I help maintain, 👍 on the feature from me! |
|
I can see this is marked as WIP but thought I'd mention:
|
|
@wjdp I agree. How about |
This adds a new option to produce a warning rather than an error for broken external links. It is quite useful for sites having hundreds of external links.
abhishalya
changed the title
AllowExternalLinksToFailIgnoreExternalBrokenLinks
|
@wjdp I've added the tests, can you have a look again :) |
|
@wjdp Any update on this one? |
wjdp
approved these changes
Jan 25, 2020
|
Sorry about delay on this! |
|
No problem, thanks for the merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do let me know if it is useful, we particularly required this while checking links for julialang.org site which has a large number of links.
I'll add tests and docs soon, if this idea looks good enough.
Closes #139
cc @wjdp