Added reaction drawing support and svg size options for reactions #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! If you could include a short example notebook showing it in use, that would be great :) |
|
@wjm41 I made the requested change and include a way to use the current version instead of the 'heatmap' in plotly which doesn't currently work due to the list-of-lists specification. This nicely gets around that, shows off the visualization, and is actually based on real data. Huzzah. |
|
Great! Thanks so much :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice feature addition would be the ability to visualize reaction performance and see the content of an entire reaction. This is easily supported by rdkit. The relevant code and the flexibility around the svg specification was added.