Skip to content
This repository has been archived by the owner on Mar 16, 2019. It is now read-only.

Encoded #61

Merged
merged 9 commits into from
Jul 20, 2016
Merged

Encoded #61

merged 9 commits into from
Jul 20, 2016

Conversation

jbrodriguez
Copy link
Contributor

Hi @wkh237, I'm making the request to 0.8.0, I think that's the feature branch (instead of 0.7.0)

This PR addresses two things:

  • Implement the cache key mechanism (android and ios)
  • Implement support for application/x-www-form-urlencoded (android/ios)

I'm basically using this library as a replacement for the stock React Native fetch.

This is because I hit endpoints on a non-compliant server, that doesn't respect the standard of case-insensitive headers.

React Native's fetch lowercases all headers and this forced me to manually patch it, so that it doesn't lowercase them.

I'm a couple of weeks away from setting up an ios testing environment, so truth to be told, the ios part is completely untested, but I think the general idea is there.


Thank you for making a pull request ! Just a gentle reminder :)

  1. If the PR is offering a feature please make the request to our "Feature Branch" 0.7.0
  2. Bug fix request to "Bug Fix Branch" 0.6.4
  3. Correct README.md can directly to master

@wkh237
Copy link
Owner

wkh237 commented Jul 20, 2016

Hi @jbrodriguez , this is great 👍 I think it would be very helpful if the fetch request can be a replacement of RN fetch, because I'm now working on #44 which I have to implement a XMLHttpRequest class that fully compatible with the one in Web API. I will try to merge your code with my work in progress one (which is on issue_44 branch).

@wkh237 wkh237 merged commit 4d61135 into wkh237:0.8.0 Jul 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants