Skip to content

Commit

Permalink
MAINTAINERS: disallow self-LGTMs
Browse files Browse the repository at this point in the history
Apart from being a sign of respect to other maintainers, it also ensures
that *all* pull requests get equal amounts of review -- no matter who
wrote them. Maintainers should know better than to make broken
patchsets, but it's also a sign of respect to the community that all
pull requests have equal treatment.

Signed-off-by: Aleksa Sarai <asarai@suse.de>
  • Loading branch information
cyphar committed May 27, 2016
1 parent 560fdc9 commit c82a2e7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion MAINTAINERS_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ All decisions are pull requests, and the relevant maintainers make
decisions by accepting or refusing the pull request. Review and acceptance
by anyone is denoted by adding a comment in the pull request: `LGTM`.
However, only currently listed `MAINTAINERS` are counted towards the required
two LGTMs.
two LGTMs. In addition, if a maintainer has created a pull request, they cannot
count toward the two LGTM rule (to ensure equal amounts of review for every pull
request, no matter who wrote it).

Overall the maintainer system works because of mutual respect across the
maintainers of the project. The maintainers trust one another to make decisions
Expand Down

0 comments on commit c82a2e7

Please sign in to comment.