Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dockerfile to support using over tcp rpc #17

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

Zwlin98
Copy link
Contributor

@Zwlin98 Zwlin98 commented Nov 26, 2023

提供了 Dockerfile 和 docker-compose 文件,可以一键启动 rime-ls 的 tcp 模式,并把 rime 的 user data 挂载到容器中。

Copy link
Owner

@wlh320 wlh320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile 里的 EXPOSE 端口写错了,其他看起来没什么问题

Dockerfile Outdated

COPY --from=builder /app/target/release/rime_ls /app

EXPOSE 9527
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

端口这里好像写错了,会影响运行吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

会有问题,我之前用的都是 9527, 之后看到文档中使用的都是 9257,修改的时候遗漏了一项。我再修改一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

会有问题,我之前用的都是 9527, 之后看到文档中使用的都是 9257,修改的时候遗漏了一项。我再修改一下

已修改

@wlh320
Copy link
Owner

wlh320 commented Nov 27, 2023

感谢测试 TCP 功能和贡献 docker 相关配置

@wlh320 wlh320 merged commit 375b444 into wlh320:master Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants