You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm maintaining an extension (https://github.com/michaelgriscom/LeaderMode) which leverages VSCode's type command to expand shortcut keys that jumpy clashes with. Upon being enabled, jumpy registers a custom type command, bubbling the type event to the default command if jumpy is disabled
The issue is that when the jumpy extension registers its type command other non-default listeners don't see the event, breaking other extensions (this is essentially the reverse of issue #1). I believe that a better approach would be to dispose of the command whenever jumpy is disabled, then re-register the command when it is enabled; that way the jumpy command only exists when the mode is active. I've taken that approach with LeaderMode and haven't noticed any perf impact
The text was updated successfully, but these errors were encountered:
I'm maintaining an extension (https://github.com/michaelgriscom/LeaderMode) which leverages VSCode's type command to expand shortcut keys that jumpy clashes with. Upon being enabled, jumpy registers a custom type command, bubbling the type event to the default command if jumpy is disabled
vscode-jumpy/src/extension.ts
Lines 130 to 134 in e547c8f
The issue is that when the jumpy extension registers its type command other non-default listeners don't see the event, breaking other extensions (this is essentially the reverse of issue #1). I believe that a better approach would be to dispose of the command whenever jumpy is disabled, then re-register the command when it is enabled; that way the jumpy command only exists when the mode is active. I've taken that approach with LeaderMode and haven't noticed any perf impact
The text was updated successfully, but these errors were encountered: