Skip to content

Commit

Permalink
Merge pull request #697 from wmde/old-ty-removal
Browse files Browse the repository at this point in the history
Remove old thank-you banners from HK23/24
  • Loading branch information
gbirke authored Feb 10, 2025
2 parents 651c3a5 + 0d9ad97 commit a00c8b2
Show file tree
Hide file tree
Showing 122 changed files with 978 additions and 4,449 deletions.
35 changes: 0 additions & 35 deletions banners/thank_you/MembershipFormActions.ts

This file was deleted.

17 changes: 11 additions & 6 deletions banners/thank_you/banner_ctrl.de.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createVueApp } from '@src/createVueApp';

import './styles/styles.scss';
import './styles/styles_wporg.scss';

import PageWPORG from '@src/page/PageWPORG';
import { SkinFactory } from '@src/page/skin/SkinFactory';
Expand All @@ -16,8 +16,7 @@ import Banner from './components/BannerCtrl.de.vue';
import messages from './messages.de';
import eventMappings from './event_map';
import TranslationPlugin from '@src/TranslationPlugin';
import { TrackingMembershipFormActions } from './MembershipFormActions';
import { createTrackedURL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import { createTrackedURL, MEMBERSHIP_FORM_URL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import { createThankYouSettings } from './settings';
import { IntegerDe } from '@src/utils/DynamicContent/formatters/IntegerDe';
import { Locales } from '@src/domain/Locales';
Expand All @@ -39,8 +38,15 @@ const app = createVueApp( BannerConductor, {
bannerCategory: 'fundraisingThankyou',
bannerProps: {
settings: createThankYouSettings( new IntegerDe(), page.getThankYouCampaignParameters() ),
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, Locales.DE ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, Locales.DE )
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, { locale: Locales.DE } ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, { locale: Locales.DE } ),
membershipWithAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, {
locale: Locales.DE,
interval: '1',
fee: '500',
type: 'sustaining'
} ),
membershipWithoutAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, { locale: Locales.DE, type: 'sustaining' } )
},
resizeHandler: new WindowResizeHandler(),
banner: Banner,
Expand All @@ -49,7 +55,6 @@ const app = createVueApp( BannerConductor, {

app.use( TranslationPlugin, translator );
app.provide( 'tracker', tracker );
app.provide( 'formActions', new TrackingMembershipFormActions( page.getTracking(), impressionCount, Locales.DE ) );
app.provide( 'timer', new WindowTimer() );

app.mount( page.getBannerContainer() );
17 changes: 11 additions & 6 deletions banners/thank_you/banner_ctrl.en.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createVueApp } from '@src/createVueApp';

import './styles/styles.scss';
import './styles/styles_wporg.scss';

import PageWPORG from '@src/page/PageWPORG';
import { SkinFactory } from '@src/page/skin/SkinFactory';
Expand All @@ -16,8 +16,7 @@ import Banner from './components/BannerCtrl.en.vue';
import messages from './messages.en';
import eventMappings from './event_map';
import TranslationPlugin from '@src/TranslationPlugin';
import { TrackingMembershipFormActions } from './MembershipFormActions';
import { createTrackedURL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import { createTrackedURL, MEMBERSHIP_FORM_URL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import { createThankYouSettings } from './settings';
import { IntegerEn } from '@src/utils/DynamicContent/formatters/IntegerEn';
import { Locales } from '@src/domain/Locales';
Expand All @@ -39,8 +38,15 @@ const app = createVueApp( BannerConductor, {
bannerCategory: 'fundraisingThankyou',
bannerProps: {
settings: createThankYouSettings( new IntegerEn(), page.getThankYouCampaignParameters() ),
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, Locales.EN ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, Locales.EN )
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, { locale: Locales.EN } ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, { locale: Locales.EN } ),
membershipWithAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, {
locale: Locales.EN,
interval: '1',
fee: '500',
type: 'sustaining'
} ),
membershipWithoutAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, { locale: Locales.EN, type: 'sustaining' } )
},
resizeHandler: new WindowResizeHandler(),
banner: Banner,
Expand All @@ -49,7 +55,6 @@ const app = createVueApp( BannerConductor, {

app.use( TranslationPlugin, translator );
app.provide( 'tracker', tracker );
app.provide( 'formActions', new TrackingMembershipFormActions( page.getTracking(), impressionCount, Locales.EN ) );
app.provide( 'timer', new WindowTimer() );

app.mount( page.getBannerContainer() );
17 changes: 11 additions & 6 deletions banners/thank_you/banner_ctrl.wpde.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createVueApp } from '@src/createVueApp';

import './styles/styles.scss';
import './styles/styles_wpde.scss';
import { Translator } from '@src/Translator';
import { UrlRuntimeEnvironment } from '@src/utils/RuntimeEnvironment';
import { LocalImpressionCount } from '@src/utils/LocalImpressionCount';
Expand All @@ -9,8 +9,7 @@ import { WindowResizeHandler } from '@src/utils/ResizeHandler';
import Banner from './components/BannerCtrl.de.vue';
import messages from './messages.de';
import TranslationPlugin from '@src/TranslationPlugin';
import { TrackingMembershipFormActions } from './MembershipFormActions';
import { createTrackedURL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import { createTrackedURL, MEMBERSHIP_FORM_URL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import PageWPDE from '@src/page/PageWPDE';
import { TrackerWPDE } from '@src/tracking/TrackerWPDE';
import eventMap from './event_map.wpde';
Expand Down Expand Up @@ -41,8 +40,15 @@ const app = createVueApp( BannerConductor, {
bannerCategory: 'fundraisingThankyou',
bannerProps: {
settings: createThankYouSettings( new IntegerDe(), page.getThankYouCampaignParameters() ),
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, Locales.DE ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, Locales.DE )
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, { locale: Locales.DE } ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, { locale: Locales.DE } ),
membershipWithAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, {
locale: Locales.DE,
interval: '1',
fee: '500',
type: 'sustaining'
} ),
membershipWithoutAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, { locale: Locales.DE, type: 'sustaining' } )
},
resizeHandler: new WindowResizeHandler(),
banner: Banner,
Expand All @@ -51,7 +57,6 @@ const app = createVueApp( BannerConductor, {

app.use( TranslationPlugin, translator );
app.provide( 'tracker', tracker );
app.provide( 'formActions', new TrackingMembershipFormActions( page.getTracking(), impressionCount, Locales.DE ) );
app.provide( 'timer', new WindowTimer() );

app.mount( page.getBannerContainer() );
17 changes: 11 additions & 6 deletions banners/thank_you/banner_var.de.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createVueApp } from '@src/createVueApp';

import './styles/styles.scss';
import './styles/styles_wporg.scss';

import PageWPORG from '@src/page/PageWPORG';
import { SkinFactory } from '@src/page/skin/SkinFactory';
Expand All @@ -16,8 +16,7 @@ import Banner from './components/BannerVar.de.vue';
import messages from './messages.de';
import eventMappings from './event_map';
import TranslationPlugin from '@src/TranslationPlugin';
import { TrackingMembershipFormActions } from './MembershipFormActions';
import { createTrackedURL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import { createTrackedURL, MEMBERSHIP_FORM_URL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import { createThankYouSettings } from './settings';
import { IntegerDe } from '@src/utils/DynamicContent/formatters/IntegerDe';
import { Locales } from '@src/domain/Locales';
Expand All @@ -39,8 +38,15 @@ const app = createVueApp( BannerConductor, {
bannerCategory: 'fundraisingThankyou',
bannerProps: {
settings: createThankYouSettings( new IntegerDe(), page.getThankYouCampaignParameters() ),
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, Locales.DE ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, Locales.DE )
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, { locale: Locales.DE } ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, { locale: Locales.DE } ),
membershipWithAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, {
locale: Locales.DE,
interval: '1',
fee: '500',
type: 'sustaining'
} ),
membershipWithoutAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, { locale: Locales.DE, type: 'sustaining' } )
},
resizeHandler: new WindowResizeHandler(),
banner: Banner,
Expand All @@ -49,7 +55,6 @@ const app = createVueApp( BannerConductor, {

app.use( TranslationPlugin, translator );
app.provide( 'tracker', tracker );
app.provide( 'formActions', new TrackingMembershipFormActions( page.getTracking(), impressionCount, Locales.DE ) );
app.provide( 'timer', new WindowTimer() );

app.mount( page.getBannerContainer() );
17 changes: 11 additions & 6 deletions banners/thank_you/banner_var.en.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createVueApp } from '@src/createVueApp';

import './styles/styles.scss';
import './styles/styles_wporg.scss';

import PageWPORG from '@src/page/PageWPORG';
import { SkinFactory } from '@src/page/skin/SkinFactory';
Expand All @@ -16,8 +16,7 @@ import Banner from './components/BannerVar.en.vue';
import messages from './messages.en';
import eventMappings from './event_map';
import TranslationPlugin from '@src/TranslationPlugin';
import { TrackingMembershipFormActions } from './MembershipFormActions';
import { createTrackedURL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import { createTrackedURL, MEMBERSHIP_FORM_URL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import { createThankYouSettings } from './settings';
import { IntegerEn } from '@src/utils/DynamicContent/formatters/IntegerEn';
import { Locales } from '@src/domain/Locales';
Expand All @@ -39,8 +38,15 @@ const app = createVueApp( BannerConductor, {
bannerCategory: 'fundraisingThankyou',
bannerProps: {
settings: createThankYouSettings( new IntegerEn(), page.getThankYouCampaignParameters() ),
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, Locales.EN ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, Locales.EN )
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, { locale: Locales.EN } ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, { locale: Locales.EN } ),
membershipWithAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, {
locale: Locales.EN,
interval: '1',
fee: '500',
type: 'sustaining'
} ),
membershipWithoutAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, { locale: Locales.EN, type: 'sustaining' } )
},
resizeHandler: new WindowResizeHandler(),
banner: Banner,
Expand All @@ -49,7 +55,6 @@ const app = createVueApp( BannerConductor, {

app.use( TranslationPlugin, translator );
app.provide( 'tracker', tracker );
app.provide( 'formActions', new TrackingMembershipFormActions( page.getTracking(), impressionCount, Locales.EN ) );
app.provide( 'timer', new WindowTimer() );

app.mount( page.getBannerContainer() );
17 changes: 11 additions & 6 deletions banners/thank_you/banner_var.wpde.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createVueApp } from '@src/createVueApp';

import './styles/styles.scss';
import './styles/styles_wpde.scss';
import { Translator } from '@src/Translator';
import { UrlRuntimeEnvironment } from '@src/utils/RuntimeEnvironment';
import { LocalImpressionCount } from '@src/utils/LocalImpressionCount';
Expand All @@ -9,8 +9,7 @@ import { WindowResizeHandler } from '@src/utils/ResizeHandler';
import Banner from './components/BannerVar.de.vue';
import messages from './messages.de';
import TranslationPlugin from '@src/TranslationPlugin';
import { TrackingMembershipFormActions } from './MembershipFormActions';
import { createTrackedURL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import { createTrackedURL, MEMBERSHIP_FORM_URL, SUBSCRIBE_URL, USE_OF_FUNDS_URL } from './createTrackedURL';
import PageWPDE from '@src/page/PageWPDE';
import { TrackerWPDE } from '@src/tracking/TrackerWPDE';
import eventMap from './event_map.wpde';
Expand Down Expand Up @@ -41,8 +40,15 @@ const app = createVueApp( BannerConductor, {
bannerCategory: 'fundraisingThankyou',
bannerProps: {
settings: createThankYouSettings( new IntegerDe(), page.getThankYouCampaignParameters() ),
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, Locales.DE ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, Locales.DE )
subscribeURL: createTrackedURL( SUBSCRIBE_URL, page.getTracking(), impressionCount, { locale: Locales.DE } ),
useOfFundsURL: createTrackedURL( USE_OF_FUNDS_URL, page.getTracking(), impressionCount, { locale: Locales.DE } ),
membershipWithAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, {
locale: Locales.DE,
interval: '1',
fee: '500',
type: 'sustaining'
} ),
membershipWithoutAmountURL: createTrackedURL( MEMBERSHIP_FORM_URL, page.getTracking(), impressionCount, { locale: Locales.DE, type: 'sustaining' } )
},
resizeHandler: new WindowResizeHandler(),
banner: Banner,
Expand All @@ -51,7 +57,6 @@ const app = createVueApp( BannerConductor, {

app.use( TranslationPlugin, translator );
app.provide( 'tracker', tracker );
app.provide( 'formActions', new TrackingMembershipFormActions( page.getTracking(), impressionCount, Locales.DE ) );
app.provide( 'timer', new WindowTimer() );

app.mount( page.getBannerContainer() );
Loading

0 comments on commit a00c8b2

Please sign in to comment.