Add ADR for test markers #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirke
force-pushed
the
adr-test-markers
branch
from
d852b7d to
1ed9762
Compare
gbirke
pushed a commit
that referenced
this pull request
Dec 4, 2024
We wanted to optimize the markup for the close button, but ran into issues where the test code depended on the class `wmde-banner-mini-close-button` being present. We added back the class to make the tests pass, but will optimize our tests and markup. Tracked in #645 Ticket: https://phabricator.wikimedia.org/T380854
Suggestion for a separation of concerns between naming elements for styling and naming them for referencing them in tests.
gbirke
force-pushed
the
adr-test-markers
branch
from
1ed9762 to
7c3090f
Compare
|
As Abban suggested during the campaign, let's keep the ideas around this topic as an ADR (that we could revisit), but ultimately reject it and do nothing. Please give a review as a signal that you had another look at the PR |
moiikana
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for a separation of concerns between naming elements for styling and naming them for referencing them in tests.