Remove unused AlreadyDonatedModal #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiikana
force-pushed
the
already-donated-modal-removal
branch
2 times, most recently
from
cdfcd92 to
8af8926
Compare
- the banners use a simple link/"button" to trigger a close/maybelater event currently - rename the AlreadyDonatedModal feature tests to AlreadyDonatedLink and remove all tests around the former modal https://phabricator.wikimedia.org/T384044
moiikana
force-pushed
the
already-donated-modal-removal
branch
from
8af8926 to
bfbbcf6
Compare
gbirke
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T384044