Improve form action domain model #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the next step of the refactoring, we'll introduce domain objects for the form actions and call them "Actions" as well, so I'll rename the form actions with the suffix `Url` to signify that they are URL strings. Ticket: https://phabricator.wikimedia.org/T383980
We need to modify the form actions dynamically during A/B tests and want to encapsulate the URL generation logic inside an API. This commit is backwards-compatible with the existing `FormActions` interface, but deprecates it. Since the impression counting is non-reactive but tries to be reactive, we don't put it as a dependency of `FormAction`. When it becomes reactive, we should change the constructor of `FormAction` and hand over the impression counting class as a dependency. Ticket: https://phabricator.wikimedia.org/T383980
gbirke
force-pushed
the
improve-form-action
branch
from
5755bf6 to
d4c664f
Compare
Use `FormActionCollection` with domain objects instead in both composables (`useFormAction` and `useFormActionWithReceipt`) Create `fakeFormActions` fixture with `FormActionCollection` and use it in all tests that previously used the string-based `formActions` injection. Ticket: https://phabricator.wikimedia.org/T383980
gbirke
force-pushed
the
improve-form-action
branch
from
d4c664f to
f951655
Compare
moiikana
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://phabricator.wikimedia.org/T383980