Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11-03 Meaning of time stamp: fix definitions of 'beginning' and 'end' #204

Closed
amilan17 opened this issue Nov 16, 2020 · 9 comments
Closed
Assignees
Milestone

Comments

@amilan17
Copy link
Member

amilan17 commented Nov 16, 2020

Branch
https://github.com/wmo-im/wmds/tree/issue204

https://github.com/wmo-im/wmds/blob/issue204/tables_en/11-03.csv

Summary and Purpose
The definition of beginning reads as end, and end is a duplicate of middle. The problem traces back to the approved text from CBS-16 page 717.

Stakeholder
https://github.com/citterio
Reported by @iosifescu in EnviDat/monitoring-backend#2 (comment)

Proposal
See details in pull request.
https://github.com/wmo-im/wmds/pull/192/files

@joergklausen
Copy link
Contributor

@amilan17 Please create branch.
@gaochen_larc @RMaerz Please confirm branch

@amilan17
Copy link
Member Author

created and edited branch -- ready for review

@gaochen-larc
Copy link
Contributor

gaochen-larc commented Dec 17, 2020 via email

@gaochen-larc
Copy link
Contributor

gaochen-larc commented Dec 22, 2020

Made one comment on "Beginning", Please consider replacing "following" by "subsequent". This proposed change is not critical. All changes look fine. Thanks!

Just a note, the "Middle" time stamp can be critical when the sampling is uneven... We run into an issue with a canister measurement.

@joergklausen joergklausen removed their assignment Jan 14, 2021
@amilan17
Copy link
Member Author

@fstuerzl - add subsequent

ask original requester to review final solution.

@fstuerzl
Copy link
Member

Branch updated: https://github.com/wmo-im/wmds/blob/issue204/tables_en/11-03.csv
@citterio, @gaochen-larc, please confirm the branch.

@gaochen-larc
Copy link
Contributor

confirm. Thanks!

@joergklausen
Copy link
Contributor

@citterio Can you please identify yourself and also confirm that you are in agreement with the solution to this issue?

@amilan17
Copy link
Member Author

accept as is and notify @citterio in their original PR

@amilan17 amilan17 linked a pull request Jan 25, 2021 that will close this issue
@amilan17 amilan17 removed a link to a pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants