-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11-03 Meaning of time stamp: fix definitions of 'beginning' and 'end' #204
Comments
created and edited branch -- ready for review |
Made one comment on "Beginning", Please consider replacing "following" by "subsequent". This proposed change is not critical. All changes look fine. Thanks! Just a note, the "Middle" time stamp can be critical when the sampling is uneven... We run into an issue with a canister measurement. |
@fstuerzl - add subsequent ask original requester to review final solution. |
Branch updated: https://github.com/wmo-im/wmds/blob/issue204/tables_en/11-03.csv |
confirm. Thanks! |
@citterio Can you please identify yourself and also confirm that you are in agreement with the solution to this issue? |
accept as is and notify @citterio in their original PR |
Branch
https://github.com/wmo-im/wmds/tree/issue204
https://github.com/wmo-im/wmds/blob/issue204/tables_en/11-03.csv
Summary and Purpose
The definition of beginning reads as end, and end is a duplicate of middle. The problem traces back to the approved text from CBS-16 page 717.
Stakeholder
https://github.com/citterio
Reported by @iosifescu in EnviDat/monitoring-backend#2 (comment)
Proposal
See details in pull request.
https://github.com/wmo-im/wmds/pull/192/files
The text was updated successfully, but these errors were encountered: