-
Notifications
You must be signed in to change notification settings - Fork 492
Update tsconfig to support dynamic import #115
Conversation
@wmonk using esnext seems to have an impact on tests (SyntaxError: Unexpected token import). |
@wmonk only a temporary fix (for jest) because TS_CONFIG is deprecated |
What about creating a I.e.: {
"extends": "./tsconfig.json",
"compilerOptions": {
"module": "commonjs"
}
} Add corresponding path entries in this file, e.g. It's a bit tricky, but different
Using different config files for both situations should be the way to go here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wmonk:
Change looks good technically. Your turn now :)
Thanks! |
resolves #90
In order to make code splitting work, we have to set the module to esnext in tsconfig.json