Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

add typechecking to tslint #140

Closed
wants to merge 1 commit into from
Closed

add typechecking to tslint #140

wants to merge 1 commit into from

Conversation

GabrielCastro
Copy link

This solves #126,
I ran eject on a project made these changes and no longer get the flash error from tslint

@gsteacy
Copy link

gsteacy commented Aug 26, 2017

I'm not sure type checking should be enabled while this is still an issue: wbuchwalter/tslint-loader#76. Even on small projects I noticed a performance hit of 250-300%.

@pelotom
Copy link
Contributor

pelotom commented Sep 26, 2017

@gsteacy agreed, I've stopped using tslint-loader and switched to tslint-webpack-plugin because of this.

@stevenmusumeche
Copy link

@pelotom are you able to do that without ejecting though?

@pelotom
Copy link
Contributor

pelotom commented Sep 27, 2017

@stevenmusumeche no.

@wmonk
Copy link
Owner

wmonk commented Jan 14, 2018

As this issue hasn't been updated for a while, I am going to close it. If there are any updates feel free to re-open and comment. 👍

@wmonk wmonk closed this Jan 14, 2018
@DorianGrey
Copy link
Collaborator

FYI: fork-ts-checker-webpack-plugin, which was added in 2.10, supports linting rules that require type checking by sharing ts.Program instances, so that feature should be available anyway.

@pelotom
Copy link
Contributor

pelotom commented Jan 15, 2018

Yes, however be aware that fork-ts-checker-webpack-plugin has a bug with the no-unused-variable rule which may or may not bite you. For my project it was intolerable; I had to disable the rule and use the tsc —noUnusedLocals flag instead.

@DorianGrey
Copy link
Collaborator

That's currently the case in the template - noUnusedLocals is used as a compiler option, no-unused-variable is not part of the linter config.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants