This repository has been archived by the owner on Jan 26, 2019. It is now read-only.
Include TypeScript as devDependency in boilerplate output #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we expect this to be merged/released at any point soon? |
|
@ianschmitz could you update this to fix merge conflicts? |
|
Yes I can. Won't be until end of week since I'm out of country. |
|
Should be good to go now 👍 |
|
Released in 2.13.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85.
This will remove
typescriptfromreact-scripts-tsand instead include it as adevDependencyin the boilerplate output.Note that I have added it as a
peerDependencyinreact-scripts-ts. I think this is the right way to handle it, as users upgrading from 2.x ofreact-scripts-tswould see anUNMET PEER DEPENDENCYduring an install. However this means that when creating a new app the user will see this: