This repository has been archived by the owner on Jan 26, 2019. It is now read-only.
Remove tslint-loader from prod build (again) #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was just about to do exactly the same! |
caghand
reviewed
Jan 22, 2018
| @@ -136,17 +136,6 @@ module.exports = { | |||
| module: { | |||
| strictExportPresence: true, | |||
| rules: [ | |||
| // TODO: Disable require.ensure as it's not a standard language feature. | |||
There was a problem hiding this comment.
You do not need to remove these three lines starting with "TODO". As far as I can see, they are not related to the tslint-loader block. (Correct me if I am wrong.) I am pointing this out because webpack.config.dev.js still has these three lines. :)
There was a problem hiding this comment.
Thanks for the hint - updated!
|
Ah whoops this was my fault |
wmonk
approved these changes
Jan 22, 2018
DorianGrey
force-pushed
the
remove-tslint-loader
branch
from
0fedbfa
to
b40c8c5
Compare
|
Released in 2.13.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just been notified that
tslint-loadersomehow made it into the production config again: #165 (comment)This one is not required due to the
fork-ts-checker.