Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

add missing step (install typescript) #243

Closed
wants to merge 2 commits into from
Closed

Conversation

kandros
Copy link

@kandros kandros commented Jan 27, 2018

since TS is not a peer dependency

@DorianGrey
Copy link
Collaborator

DorianGrey commented Jan 27, 2018

This should not be required, since this installation is triggered by the init script, along with various types:

const types = [
'@types/node',
'@types/react',
'@types/react-dom',
'@types/jest',
'typescript',
];
console.log(
`Installing ${types.join(', ')} as dev dependencies ${command}...`
);
console.log();
const devProc = spawn.sync(command, args.concat('-D').concat(types), {
stdio: 'inherit',
});
if (devProc.status !== 0) {
console.error(`\`${command} ${args.concat(types).join(' ')}\` failed`);
return;
}

Is there any known issue with this procedure?

@kandros
Copy link
Author

kandros commented Jan 27, 2018

Ok, I was updating from a previous version, and was worried about it not being installed, had to look in various commit to undertand why it wasn’t managed by react-scripts-ts anymore.

Maybe we should make it more explicit in the changelog, pr move ot in the postinstall.

@caghand
Copy link

caghand commented Jan 27, 2018

Yeah, it has been reported before: #241

@DorianGrey
Copy link
Collaborator

Added instructions to the README: https://github.com/wmonk/create-react-app-typescript#from-2130-to-2130

@DorianGrey DorianGrey closed this Jan 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants